Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: Update the GraphQL model with the last execution #486

Merged
merged 4 commits into from
Nov 10, 2021

Conversation

tpalashki
Copy link
Contributor

Extended the GraphQL and service models to reflect the properties that were added
as part of the implementation of the ability to sort and filter data jobs by their
last execution status, time, and duration.

Wire the two models so that the newly added properties can be queried via GraphQL.

Testing done: Run the service locally and verified that the new properties are
returned when requested.

Signed-off-by: Tsvetomir Palashki [email protected]

Extended the GraphQL and service models to reflect the properties that were added
as part of the implementation of the ability to sort and filter data jobs by their
last execution status, time, and duration.

Wire the two models so that the newly added properties can be queried via GraphQL.

Testing done: Run the service locally and verified that the new properties are
returned when requested.

Signed-off-by: Tsvetomir Palashki <[email protected]>
@mivanov1988
Copy link
Collaborator

LGTM: do we have any tests for this?

@tpalashki
Copy link
Contributor Author

I haven't added tests yet as it is mostly plumbing code. I will cover when I have the actual implementation of the filtering/sorting in place.

@mivanov1988
Copy link
Collaborator

I haven't added tests yet as it is mostly plumbing code. I will cover when I have the actual implementation of the filtering/sorting in place.

Yes, but since it is possible to adopt it in production it may be a good idea to add some.

@tpalashki tpalashki merged commit 988f7cc into main Nov 10, 2021
@tpalashki tpalashki deleted the person/tpalashki/current branch November 10, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants