control-service: Classify OOM as User Errors #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
approved these changes
Nov 5, 2021
...rol_service/src/main/java/com/vmware/taurus/service/execution/JobExecutionResultManager.java
Outdated
Show resolved
Hide resolved
|
Are you sure that the |
doks5
force-pushed
the
person/andonova/fix-oom-error
branch
3 times, most recently
from
95bf58e to
ec81690
Compare
tpalashki
reviewed
Nov 8, 2021
...rol_service/src/main/java/com/vmware/taurus/service/execution/JobExecutionResultManager.java
Outdated
Show resolved
Hide resolved
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Outdated
Show resolved
Hide resolved
mivanov1988
reviewed
Nov 8, 2021
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-oom-error
branch
from
ec81690 to
64935b2
Compare
doks5
force-pushed
the
person/andonova/fix-oom-error
branch
from
64935b2 to
c54d9ed
Compare
tpalashki
reviewed
Nov 8, 2021
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Outdated
Show resolved
Hide resolved
...rol_service/src/main/java/com/vmware/taurus/service/execution/JobExecutionResultManager.java
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-oom-error
branch
from
c54d9ed to
5535add
Compare
tpalashki
approved these changes
Nov 9, 2021
...cts/pipelines_control_service/src/main/java/com/vmware/taurus/service/KubernetesService.java
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/fix-oom-error
branch
from
5535add to
e8891c2
Compare
Currently, if a data job execution exceeds the allowed memory quota, the pod of the execution is immediately killed by Kubernetes and restarted. Which in turn usually results in a similar failure. This causes a Platform Error to be raised, whereas it should be classified as a User Error. This change re-classifies such errors as User Errors. Testing Done: Added unit test. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/fix-oom-error
branch
from
e8891c2 to
4c1359d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a data job execution exceeds the allowed memory
quota, the pod of the execution is immediately killed by
Kubernetes and restarted. Which in turn usually results in a
similar failure. This causes a Platform Error to be raised, whereas
it should be classified as a User Error.
This change re-classifies such errors as User Errors.
Testing Done: Added unit test.
Signed-off-by: Andon Andonov [email protected]