-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: GraphQL executions query #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
reviewed
Nov 5, 2021
projects/control-service/projects/pipelines_control_service/src/main/resources/schema.graphqls
Outdated
Show resolved
Hide resolved
Yes, I think that's the way to go. I really like the where clause approach. I have played with the ontotext tutorial it is pretty good. |
antoniivanov
approved these changes
Nov 8, 2021
3de7f4a
to
f9d234f
Compare
Extended the GraphQL schema (resources/schema.graphqls) by adding an additional query called executions. It will allow us to filter and sort executions by the following fields: status, startTime, endTime. Sample request: ``` {{ baseUrl }}/data-jobs/for-team/no-team-specified/jobs?query={ executions(filter: { endTimeGte: "2021-10-19T10:14:47Z", statusIn: [FAILED, CANCELLED] }, order: {property: "endTime", sort: DESC}) { content { id startTime endTime status jobName } } } ``` Еvaluated an advanced filtering approach, but it seems to be out of scope of this issue. It will take more implementation time since we should introduce a new query engine. ``` {{ baseUrl }}/data-jobs/for-team/no-team-specified/jobs?query={ executions(filter: [ {op: gte, property: "endTime", value: "2021-10-19T10:14:47Z"}, {op: in, property: "status", values: ["failed", "cancelled"]} ], order: {property: "status", sort: DESC}) { content { id startTime endTime status jobName } } } ``` Testing: unit tests Signed-off-by: Miroslav Ivanov [email protected]
c9a9d05
to
f734cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the GraphQL schema (resources/schema.graphqls) by adding
an additional query called executions. It will allow us to filter
and sort executions by the following fields: status, startTime, endTime.
Sample request:
Еvaluated an advanced filtering approach, but it seems to be out of scope
of this issue. It will take more implementation time since we should
introduce a new query engine.
Testing: unit tests
Signed-off-by: Miroslav Ivanov [email protected]