control-service: Turn-off debug mode for builder script #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/turn-off-debug-mode
branch
from
09265f0 to
288c212
Compare
Builder job pods run a shell script, which builds and uploads the data job image. Currently, it runs in debug mode which is not needed in production environments. This change turns off debug mode, and logs only required and non-sensitive steps. Testing Done: Uploaded new builder job image to docker hub, and ran a local instance of the Control Service to verify that only necessary data is logged. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/turn-off-debug-mode
branch
from
288c212 to
f1788ff
Compare
? |
Oopsie, I updated the commit message, but I forgot to edit the PR message. :) |
antoniivanov
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builder job pods run a shell script, which builds and uploads the
data job image. Currently, it runs in debug mode which is not needed
in production environments.
This change turns off debug mode, and logs only required and non-sensitive
steps.
Testing Done: Uploaded new builder job image to docker hub, and ran a local
instance of the Control Service to verify that only necessary data is logged.
Signed-off-by: Andon Andonov [email protected]