control-service: extend PATCH deployments semantics #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/control-service-api
branch
from
885539d to
995af11
Compare
antoniivanov
force-pushed
the
person/aivanov/control-service-api
branch
from
a2f0714 to
39acf73
Compare
antoniivanov
force-pushed
the
person/aivanov/control-service-api
branch
2 times, most recently
from
f02f42a to
7555d32
Compare
mivanov1988
approved these changes
Nov 4, 2021
Until now only enable/disabled flag of a data job deployment could be patched. Now this is changed so any field (except job_version) can be patched. This will enable for more dynamic configuration of data job deployments. In subsequent PR we can add ability to patch vdk_version. See operation summary for more details. Testing Done: ran integration tests and unit tests. Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/control-service-api
branch
from
7555d32 to
1e52a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now only enable/disabled flag of a data job deployment could be
patched. Now this is changed so any field (except job_version) can be
patched. This will enable for more dynamic configuration of data job
deployments. In subsequent PR we can add ability to patch vdk_version.
See operation summary for more details.
Signed-off-by: Antoni Ivanov [email protected]