[control-service]:fix memoryToMB conversion overflow in KubernetesService #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <[email protected]>
mrMoZ1
force-pushed
the
person/mzhivkov/fix-resource-memory
branch
from
12efae0 to
5a595db
Compare
mivanov1988
reviewed
Nov 1, 2021
...pipelines_control_service/src/test/java/com/vmware/taurus/service/KubernetesServiceTest.java
Show resolved
Hide resolved
|
Good job. |
Signed-off-by: mrMoZ1 <[email protected]>
mivanov1988
reviewed
Nov 1, 2021
...pipelines_control_service/src/test/java/com/vmware/taurus/service/KubernetesServiceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
mivanov1988
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why: We noticed in the logs that a running control service
would update a data job execution with a negative value for
memory allocation. As a user I want to know for certain the
allocated memory resources for a data job and a negative
value is an obvious bug.
what: Changed culprit function's implementation to use BigInteger instead
of int as the calculations it was performing would easily overflow the int
value at around 2gb or more.
testing: Added unit tests that verify function is working as intended
on small and large conversion numbers.
Signed-off-by: Momchil Zhivkov [email protected]