contro-service: revert some logic related to false-positive emails #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails Last batch of changes to handle false-positive notifications introduced logic that skips updating the last_job_termination_status of a data job if it is NONE or null. This was incorrect because of how we find the execution_id inside rules: by cross-referencing to the last kube_job_status_start_time metric. In this case, if the last execution terminated with an error and a new execution starts, we will cross-reference the last termination status (error) with the new job execution and will send a notification. This commit reverts the old logic that sents the last_job_termination_status to NONE when a new execution starts. Testing done: unit tests Signed-off-by: Tsvetomir Palashki <[email protected]>
mivanov1988
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last batch of changes to handle false-positive notifications introduced
a logic that skips updating the last_job_termination_status of a data job
if it is NONE or null.
This was incorrect because of how we find the execution_id inside rules: by
cross-referencing to the last kube_job_status_start_time metric. In this case, if
the last execution terminated with an error and a new execution starts, we will
cross-reference the last termination status (error) with the new job execution
and will send a notification.
This commit reverts the old logic that sents the last_job_termination_status
to NONE when a new execution starts.
Testing done: unit tests
Signed-off-by: Tsvetomir Palashki [email protected]