control-service: Remove logging of credentials in builder #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
force-pushed
the
person/andonova/remove-creds-from-builder
branch
7 times, most recently
from
edac7d6 to
e62799f
Compare
Currently, we are leaking AWS credentials in builder pods. These are then logged, which is a security concern. This change removes the leaked credentials from the logs. Testing Done: Manually changed the version of the builder job to a dev version, in order to push an image to docker hub. Afterwards, started a local instance of Control Service, and manually deployed a test data job and verified that the AWS credentials are no longer being logged. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/remove-creds-from-builder
branch
from
e62799f to
4c00572
Compare
mivanov1988
approved these changes
Nov 2, 2021
|
Just to remind you that you should change the helm chart builder version in a separate PR. |
antoniivanov
reviewed
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are leaking AWS credentials in builder pods. These
are then logged, which is a security concern.
This change removes the leaked credentials from the logs.
Testing Done: Manually changed the version of the builder job to a
dev version, in order to push an image to docker hub. Afterwards, started
a local instance of Control Service, and manually deployed a test data job
and verified that the AWS credentials are no longer being logged.
Signed-off-by: Andon Andonov [email protected]