control-service: Fix authentication when pulling images #456
Conversation
YanaZhivkova
force-pushed
the
person/yzhivkova/Fix_authentication_when_pulling_Data_Job_image_on_execute
branch
from
ab4f94e to
e977755
Compare
|
Can you please link the github issue :
|
|
I have not looked at the code yet (as it is in draft). But I am not sure I mentioned and it's documented but just in case. Our helm chart follow bitnami style - there are a lot of charts in bitnami repo: https://github.com/bitnami/charts/tree/master/bitnami So make sure to reuse what they've done there. |
|
Did you evaluate the following approach - https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account? |
YanaZhivkova
force-pushed
the
person/yzhivkova/Fix_authentication_when_pulling_Data_Job_image_on_execute
branch
from
e977755 to
5d09f57
Compare
Done. |
YanaZhivkova
force-pushed
the
person/yzhivkova/Fix_authentication_when_pulling_Data_Job_image_on_execute
branch
4 times, most recently
from
7f0c900 to
636fd78
Compare
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
...ontrol-service/projects/helm_charts/pipelines-control-service/templates/secret_pull_img.yaml
Show resolved
Hide resolved
...ontrol-service/projects/helm_charts/pipelines-control-service/templates/secret_pull_img.yaml
Show resolved
Hide resolved
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
.../pipelines_control_service/src/test/java/com/vmware/taurus/service/JobImageDeployerTest.java
Outdated
Show resolved
Hide resolved
YanaZhivkova
force-pushed
the
person/yzhivkova/Fix_authentication_when_pulling_Data_Job_image_on_execute
branch
from
636fd78 to
649619a
Compare
It seems like we respect the bitnami style. |
Yes, there were several discussions. We decided to stick to the initial plan - namely pass imagePullSecrets through the cron job. |
YanaZhivkova
force-pushed
the
person/yzhivkova/Fix_authentication_when_pulling_Data_Job_image_on_execute
branch
from
649619a to
5edf459
Compare
...cts/control-service/projects/helm_charts/pipelines-control-service/templates/deployment.yaml
Show resolved
Hide resolved
Some control-service instances need to store Data Job images in a private container registry, so we need to apply registry credentials when pulling Data Job images. Add secret containing dedicated read-only docker registry credentials to the pipelines_control_service helm chart and set it in cron jobs on deploy (imagePullSecrets). Tested by created, deploying and executing a Data Job against a control service instance configured to push/pull images to/from a private container registry. Signed-off-by: Yana Zhivkova <[email protected]>
YanaZhivkova
force-pushed
the
person/yzhivkova/Fix_authentication_when_pulling_Data_Job_image_on_execute
branch
from
5edf459 to
a6b975e
Compare
YanaZhivkova
deleted the
person/yzhivkova/Fix_authentication_when_pulling_Data_Job_image_on_execute
branch
Some control-service instances need to store Data Job
images in a private container registry, so we need to
apply registry credentials when pulling Data Job images.
Add secret containing docker registry credentials to the
pipelines_control_service helm chart and set it in
cron jobs on deploy (imagePullSecrets).
Tested by created, deploying and executing a Data Job
against a control service instance configured to push/pull
images to/from a private container registry.
Signed-off-by: Yana Zhivkova [email protected]