Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-control-cli: fix warning message not to crash #353

Merged
merged 1 commit into from
Oct 6, 2021
Merged

vdk-control-cli: fix warning message not to crash #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def __download_key(self, team, name, path):
why=f"Error is: {e}",
consequence="Local execution of the job might fail since the job may not have permissions to some resources",
countermeasure="Try to manually download the data job keytab with vdk",
)
).message
)

def validate_job_path(self, path: str, name: str) -> None:
Expand Down
2 changes: 1 addition & 1 deletion projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/deploy_cli_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def __cleanup_archive(archive_path: str) -> None:
why=f"VDK CLI did not clean up after deploying: {e}",
consequence="There is a leftover archive file next to the folder containing the data job",
countermeasure="Clean up the archive file manually or leave it",
)
).message
)

def __update_data_job_deploy_configuration(
Expand Down
2 changes: 1 addition & 1 deletion projects/vdk-control-cli/src/vdk/internal/control/command_groups/job/download_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def __cleanup_archive(archive_path: str):
why=f"VDK CLI did not clean up after deploying: {e}",
consequence="There is a leftover archive file next to the folder containing the data job",
countermeasure="Clean up the archive file manually or leave it",
)
).message
)


Expand Down