vdk-test-utils: Measure payload size with len, not getsizeof #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the size of payloads was measured using sys.getsizeof when testing. This is suboptimal, since different versions of Python might give different sizes (and in particular, when using Python3.12, the size of payloads is 8 bytes less than in previous versions). To address this, we now use len to measure the payload size, which should be consistent across all Python versions. The relevant tests in vdk-core have been adjusted to address this change. Testing done: cicd Signed-off-by: Gabriel Georgiev <[email protected]>
yonitoo
approved these changes
Feb 23, 2024
DeltaMichael
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the size of payloads was measured using sys.getsizeof when testing. This is suboptimal, since different versions of Python might give different sizes (and in particular, when using Python3.12, the size of payloads is 8 bytes less than in previous versions). To address this, we now use len to measure the payload size, which should be consistent across all Python versions.
The relevant tests in vdk-core have been adjusted to address this change.
Testing done: cicd