versatile-data-kit: Support for Py3.12 #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a CICD job checking that components and plugins can be built and tested in a Py3.12 environment. Testing done: cicd Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
|
tap-rest-api-msdk is not a dependency of vdk-singer. It is a dependency of its tests. But we can use another tap for testing. Also vdk-singer is a pre-alpha plugin (aka prototype) . So let's not put too much effort for now there. We can just open a ticket and address it when we decide to invest more in vdk-singer. |
antoniivanov
approved these changes
Feb 23, 2024
yonitoo
approved these changes
Feb 26, 2024
Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CICD job checking that components and plugins can be built and tested in a Py3.12 environment.
vdk-singerdoes not support 3.12 as its dependencytap-rest-api-msdkexplicitly does not support it.vdk-ingest-http's tests seem to fail in an odd way - this is described in this issue I've created - #3153Testing done: cicd