examples: adopt RAG examples for remote execution #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you elaborate on what non-local file local storage means ? |
murphp15
reviewed
Feb 15, 2024
antoniivanov
force-pushed
the
person/aivanov/dag
branch
from
c10760d to
b279626
Compare
murphp15
reviewed
Feb 15, 2024
| @@ -189,3 +192,6 @@ def run(job_input: IJobInput): | |||
| data_file, | |||
| confluence_reader.fetch_all_pages_in_confluence_space(parent_page_id), | |||
| ) | |||
|
|
|||
| storage = DatabaseStorage(get_value(job_input, "storage_connection_string")) | |||
There was a problem hiding this comment.
you are saving all information to one row in the database?
There was a problem hiding this comment.
Yeah. Because before it was saved to a file and I just replace the line to save to a file , to save it in DB.
I supposed I was too lazy to write a for loop
murphp15
reviewed
Feb 15, 2024
|
can you remove the duplicated classes? |
murphp15
reviewed
Feb 15, 2024
murphp15
reviewed
Feb 15, 2024
Updated description of PR |
antoniivanov
force-pushed
the
person/aivanov/dag
branch
2 times, most recently
from
83f8a14 to
276fca1
Compare
murphp15
approved these changes
Feb 16, 2024
duyguHsnHsn
reviewed
Feb 16, 2024
duyguHsnHsn
reviewed
Feb 16, 2024
duyguHsnHsn
approved these changes
Feb 16, 2024
antoniivanov
force-pushed
the
person/aivanov/dag
branch
from
276fca1 to
395a22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to run the RAG DAG in a deployment we need non-local file local storage.
The POC was build to pass data between jobs using a local file. Since I want to deploy the jobs I need a way to pass data between them without that since they do not share a file system. Postgres based storage was created for that.
So moved created one and adopt it.
It's currently copied in both jobs. I will refactor it away after this PR.
I also ended up removing NLKT from everywhere. And also few doc fixes