vdk-core: relevant info in step result #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/relevant-info-step
branch
from
8ac66dd to
d6c7449
Compare
projects/vdk-core/src/vdk/internal/builtin_plugins/run/cli_run.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/run/cli_run.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/run/cli_run.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/run/cli_run.py
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/relevant-info-step
branch
2 times, most recently
from
f8f358f to
641621b
Compare
Why? Sometimes the exact errors in user code are hard to find in the stack trace What? Print relevant information from stack trace in step results How was this tested? Ran locally Functional test What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/relevant-info-step
branch
from
641621b to
c1e1b84
Compare
duyguHsnHsn
approved these changes
Feb 1, 2024
antoniivanov
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Sometimes the exact errors in user code are hard to find in the stack trace
What?
Print relevant information from stack trace in step results
Example:
On error in step 20_python_step.py, the short result summary looks like this
How was this tested?
Ran locally
Functional test
What kind of change is this?
Feature/non-breaking