vdk-core: fix exception cause swallowing #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? report_and_throw swallows the actual exception cause if we don't pass a cause What? Remove the cause parameter (it's not used anywhere) How was this tested? CI What kind of change is this? Bugfix Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/fix-exception-cause-swallow
branch
from
d4772f5 to
a16c288
Compare
murphp15
approved these changes
Nov 28, 2023
duyguHsnHsn
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
report_and_throw swallows the actual exception cause if we don't pass a cause
What?
Remove the cause parameter (it's not used)
How was this tested?
CI
What kind of change is this?
Bugfix