vdk-oracle: support type inference #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
commented
Nov 27, 2023
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/vdk-oracle-type-inference
branch
from
4861209 to
5dc685b
Compare
gabrielgeorgiev1
approved these changes
Nov 28, 2023
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/ingest_to_oracle.py
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/vdk-oracle-type-inference
branch
2 times, most recently
from
566bc6e to
3b9e8cb
Compare
Why? Inferring the type in case a string is passed in the payload instead of the corresponding data type improves the user experience Type conversion can be relegated to vdk instead of doing pre-processing of large payloads inside data jobs What? Add column data types to column cache In case a string is passed, infer the python data type based on the Oracle column data type In case math.nan is passed, write NULL to the Oracle table How was this tested? Ran functional tests locally CI/CD What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/vdk-oracle-type-inference
branch
from
3b9e8cb to
d8b4d97
Compare
murphp15
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Inferring the type in case a string is passed in the payload instead of the corresponding data type improves the user experience. Type conversion can be relegated to vdk instead of doing pre-processing of large payloads inside data jobs
What?
Add column data types to column cache
In case a string is passed, infer the python data type based on the Oracle column data type.
In case math.nan is passed, write NULL to the Oracle table
How was this tested?
Ran functional tests locally
CI/CD
What kind of change is this?
Feature/non-breaking