control-plane: remove needless step in docker build. #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonitoo
approved these changes
Nov 27, 2023
gabrielgeorgiev1
approved these changes
Nov 27, 2023
mivanov1988
deleted the
person/murphp15/remove_needless_step_in_build
branch
murphp15
added a commit
that referenced
this pull request
Nov 28, 2023
# Why I want to release the changes made in this PR #2947 Co-authored-by: paulm2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Between each step in a docker build it needs to save a snapshot of the system.
Some operations actually require unpacking layers created before it.
This python -V is a really expensive operation.
Because it needs to unpack all the layers that came before it to run that command.
from the logs we can see
What
I removed the operation because it actually has no impact.
How was this tested?
I will deploy in CICD env and test when I get approvals.
I want it removed incase there is some context I am missing.