vdk-core: add logging plugin warning and check if the vdk-structlog plugin is used #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
gabrielgeorgiev1
approved these changes
Nov 27, 2023
…rning-and-env-var
projects/vdk-core/src/vdk/internal/builtin_plugins/config/log_config.py
Outdated
Show resolved
Hide resolved
DeltaMichael
approved these changes
Nov 29, 2023
Signed-off-by: Yoan Salambashev <[email protected]>
yonitoo
force-pushed
the
topic/ysalambashev/vdk-core-add-structlog-warning-and-env-var
branch
from
d1713e7 to
b693998
Compare
…rning-and-env-var
yonitoo
deleted the
topic/ysalambashev/vdk-core-add-structlog-warning-and-env-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This is part of #2813 which is addressed by #2939. Add logging plugin warning and check if the vdk-structlog plugin is used by checking the dedicated env var VDK_USE_STRUCTLOG.
Why: To notify the user about the logging configuration changes and to guide them to use vdk-structlog instead.