control-service: deployment cannot be suspended #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
approved these changes
Nov 27, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/deploy/DeploymentServiceV2.java
Outdated
Show resolved
Hide resolved
mivanov1988
force-pushed
the
person/miroslavi/fix-syncronizer-bug
branch
2 times, most recently
from
a00e83b to
af62799
Compare
Why: The deployment cannot be disabled in case of a previously failed one. What: Added an additional logic to the DeploymentServiceV2 to handle this particular case. Testing done: IT and unit tests. Signed-off-by: Miroslav Ivanov [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The deployment cannot be suspended in the case of a previously failed one.
What:
Added additional logic to the DeploymentServiceV2 to handle this particular case.
Testing done:
IT and unit tests.
Signed-off-by: Miroslav Ivanov [email protected]