-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-structlog: default formatter #2936
Merged
duyguHsnHsn
merged 21 commits into
main
from
person/hduygu/vdk-structlog-default-formatter
Dec 4, 2023
Merged
vdk-structlog: default formatter #2936
duyguHsnHsn
merged 21 commits into
main
from
person/hduygu/vdk-structlog-default-formatter
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
583ae5b
to
4f95038
Compare
04b4e6b
to
cca5524
Compare
for more information, see https://pre-commit.ci
projects/vdk-plugins/vdk-structlog/src/vdk/plugin/structlog/constants.py
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-structlog/src/vdk/plugin/structlog/structlog_plugin.py
Show resolved
Hide resolved
3169ba3
to
0dedc3c
Compare
for more information, see https://pre-commit.ci
projects/vdk-plugins/vdk-structlog/src/vdk/plugin/structlog/formatters.py
Outdated
Show resolved
Hide resolved
DeltaMichael
suggested changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my comments and add a description to the PR.
0226d47
to
f35d80f
Compare
328df85
to
3dacb6e
Compare
7c73f7f
to
e67d945
Compare
9523e85
to
7434292
Compare
for more information, see https://pre-commit.ci
DeltaMichael
approved these changes
Dec 1, 2023
gabrielgeorgiev1
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: vdk-structlog: support the default console logger and logging configuration#2903