Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control-service: unit tests for data job persistence classes #2935

Merged
merged 4 commits into from
Dec 4, 2023

Conversation

mrMoZ1
Copy link
Contributor

@mrMoZ1 mrMoZ1 commented Nov 23, 2023

what: added unit tests and improved coverage for the following classes - DataJobsSynchronizer, DeploymentServiceV2, and JobImageDeployerV2

why: Easier issue identification

testing: n/a

Copy link
Collaborator

@dakodakov dakodakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrMoZ1 mrMoZ1 merged commit b67ce66 into main Dec 4, 2023
@mrMoZ1 mrMoZ1 deleted the person/mzhivkov/synchronizer-unit-tests branch December 4, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants