vdk-core: add datetime and bytes to decimal json encoder #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonitoo
approved these changes
Nov 21, 2023
projects/vdk-core/tests/vdk/internal/builtin_plugins/ingestion/test_ingester_utils.py
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/parse-datetime-for-oracle
branch
3 times, most recently
from
a904ca7 to
095a5ef
Compare
DeltaMichael
changed the title
DeltaMichael
force-pushed
the
person/mdilyan/parse-datetime-for-oracle
branch
2 times, most recently
from
5becc6c to
4e1ae13
Compare
murphp15
reviewed
Nov 24, 2023
projects/vdk-core/tests/functional/ingestion/jobs/test-ingest-bad-payload-job/1_ingest_step.py
Show resolved
Hide resolved
Why? As part of the work for vdk-oracle, we need to be able to pass datetime objects for ingestion. This is not possible with the current verification. What? Add datetime to the decimal json encoder Add bytes to the decimal json encoder Make the encoder return timestamp for the datetime object Make the encoder serialize bytes as a list of ints Rename DecimalJsonEncoder to IngesterJsonEncoder How was this tested Ran locally with vdk-oracle Unit and functional tests CI tests What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/parse-datetime-for-oracle
branch
from
4e1ae13 to
0037f74
Compare
murphp15
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
As part of the work for vdk-oracle, we need to be able to pass datetime objects for ingestion. This is not possible with the current verification.
What?
Add datetime to the decimal json encoder
Make the encoder return timestamp for the datetime object Rename DecimalJsonEncoder to IngesterJsonEncoder
How was this tested
Ran locally with vdk-oracle
CI tests
What kind of change is this?
Feature/non-breaking