vdk-core: handle fetchall errors for oracledb #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? vdk-oracle needs to be able to execute queries withing the vdk-framework. This requires oracle specifics to be supported inside managed_connection_base What? Add the oracle exception message for fetchall getting called after queries that do not return a result, e.g. DROP TABLE How was this tested? Ran locally using the dev version of vdk-oracle What kind of change is this? feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
antoniivanov
approved these changes
Nov 19, 2023
gabrielgeorgiev1
approved these changes
Nov 20, 2023
DeltaMichael
deleted the
person/mdilyan/oracle-managed-connection-base
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
vdk-oracle needs to be able to execute querieswithing the vdk-framework. This requires oracle
specifics to be supported inside managed_connection_base
What?
Add the oracle exception message for fetchall getting called after queries that do not return a result, e.g. DROP TABLE
How was this tested?
Ran locally using the dev version of vdk-oracle
What kind of change is this?
feature/non-breaking