control-service: ingress allow for multiple hosts #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why:
Our Helm chart currently lacks the functionality to specify multiple Ingress hosts.
What:
Enhance the Ingress template to support multiple hosts.
Testing done:
helm template
before:
```yaml
kind: Ingress
metadata:
name: release-name-pipelines-control-service
labels:
app.kubernetes.io/name: pipelines-control-service
helm.sh/chart: pipelines-control-service-0.0.1-SNAPSHOT
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
annotations:
{}
apiVersion: networking.k8s.io/v1
spec:
ingressClassName: class
rules:
- host: "vdk.com"
http:
paths:
- path: data-jobs
pathType: "ImplementationSpecific"
backend:
service:
name: release-name-ui
port:
number: 8091
- path: data-jobs
pathType: "ImplementationSpecific"
backend:
service:
name: release-name-svc
port:
number: 8092
tls:
- hosts:
- "vdk.com"
secretName: secret
```
after:
```yaml
kind: Ingress
metadata:
name: release-name-pipelines-control-service
labels:
app.kubernetes.io/name: pipelines-control-service
helm.sh/chart: pipelines-control-service-0.0.1-SNAPSHOT
app.kubernetes.io/instance: release-name
app.kubernetes.io/managed-by: Helm
annotations:
{}
apiVersion: networking.k8s.io/v1
spec:
ingressClassName: class
rules:
- host: vdk.com
http:
paths:
- path: "/data-jobs"
backend:
service:
name: release-name-svc
port:
number: 8092
- path: "/"
backend:
service:
name: release-name-ui
port:
number: 8091
tls:
- hosts:
- vdk.com
secretName: secret
```
Signed-off-by: Miroslav Ivanov [email protected]
mrMoZ1
approved these changes
Nov 16, 2023
mivanov1988
deleted the
person/miroslavi/ingress-support-for-multiple-hosts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Our Helm chart currently lacks the functionality to specify multiple Ingress hosts.
What:
Enhance the Ingress template to support multiple hosts.
Testing done:
helm template
before:
after:
Signed-off-by: Miroslav Ivanov [email protected]