Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base: initial commit #29

Merged
merged 1 commit into from
Aug 5, 2021
Merged

base: initial commit #29

merged 1 commit into from
Aug 5, 2021

Conversation

mivanov1988
Copy link
Collaborator

This is intial commit of base project into versatile-data-kit
repository.

Base project is base of all versatile data kit services.
It provides common functionalities such as exception handling,
security, logging, etc.

Testing Done: pull request CICD.

Signed-off-by: Miroslav Ivanov [email protected]

@vmwclabot
Copy link
Member

@mivanov1988, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@mivanov1988 mivanov1988 force-pushed the person/miroslavi/vdk-base branch from 3a8a8ff to 2a1cf36 Compare August 5, 2021 12:38
@antoniivanov
Copy link
Collaborator

I don't see unit tests and integration tests. I assume you plan to add them in separate change. (Which is ok for me).

@mivanov1988
Copy link
Collaborator Author

I don't see unit tests and integration tests. I assume you plan to add them in separate change. (Which is ok for me).

Yes, I am going to provide unit and integration tests as part of pipelines control service PR.

This is intial commit of base project into versatile-data-kit
repository.

Base project is base of all versatile data kit services.
It provides common functionalities such as exception handling,
security, logging, etc.

Testing Done: pull request CICD.

Signed-off-by: Miroslav Ivanov <[email protected]>
@mivanov1988 mivanov1988 force-pushed the person/miroslavi/vdk-base branch from 2a1cf36 to 22800e3 Compare August 5, 2021 13:14
@mivanov1988 mivanov1988 merged commit 7fa9a86 into main Aug 5, 2021
@mivanov1988 mivanov1988 deleted the person/miroslavi/vdk-base branch August 5, 2021 13:33
@vmwclabot
Copy link
Member

@mivanov1988, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

@vmwclabot
Copy link
Member

@mivanov1988, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants