-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-events: improve Productionizing Jupyter Notebooks README #2896
vdk-events: improve Productionizing Jupyter Notebooks README #2896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove explore from the name of hte pdf. Also what is this pdf ? We should not have pdf in source control in general.
It is the presentation for Explore i can remove it |
a0b00b7
to
6e3abfa
Compare
for more information, see https://pre-commit.ci
Yeah, we do not need it. Let's embed some of the images in the notebook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job! Apart from the minor comment I left, a nit (subjective): sometimes "Notebook" is uppercase and sometimes not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the description of the PR. It's not updated
for more information, see https://pre-commit.ci
What: Added additional information from https://github.com/versatile-data-kit-demo/productionizing-jupyter-notebooks/tree/main to the events README
Why: To make it easier for the people to launch and understand the tutorial
Signed-off-by: Duygu Hasan [email protected]