Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-events: improve Productionizing Jupyter Notebooks README #2896

Merged

Conversation

duyguHsnHsn
Copy link
Collaborator

@duyguHsnHsn duyguHsnHsn commented Nov 14, 2023

What: Added additional information from https://github.com/versatile-data-kit-demo/productionizing-jupyter-notebooks/tree/main to the events README

Why: To make it easier for the people to launch and understand the tutorial

Signed-off-by: Duygu Hasan [email protected]

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove explore from the name of hte pdf. Also what is this pdf ? We should not have pdf in source control in general.

@duyguHsnHsn
Copy link
Collaborator Author

remove explore from the name of hte pdf. Also what is this pdf ? We should not have pdf in source control in general.

It is the presentation for Explore i can remove it

@duyguHsnHsn duyguHsnHsn force-pushed the person/hduygu/vdk-events-productionizing-jupyter-notebooks branch from a0b00b7 to 6e3abfa Compare November 14, 2023 09:03
@antoniivanov
Copy link
Collaborator

remove explore from the name of hte pdf. Also what is this pdf ? We should not have pdf in source control in general.

It is the presentation for Explore i can remove it

Yeah, we do not need it. Let's embed some of the images in the notebook.
We want this tutorial to be usable in multiple events

Copy link
Contributor

@yonitoo yonitoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job! Apart from the minor comment I left, a nit (subjective): sometimes "Notebook" is uppercase and sometimes not.

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the description of the PR. It's not updated

@antoniivanov antoniivanov enabled auto-merge (squash) November 17, 2023 09:02
@antoniivanov antoniivanov merged commit 796c20e into main Nov 17, 2023
@antoniivanov antoniivanov deleted the person/hduygu/vdk-events-productionizing-jupyter-notebooks branch November 17, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants