Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-logging-format: Deprecate plugin #2888

Merged
merged 3 commits into from
Nov 13, 2023
Merged

vdk-logging-format: Deprecate plugin #2888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e64ca7f
vdk-logging-format: Deprecate plugin
gabrielgeorgiev1 Nov 9, 2023
e3e90dc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 9, 2023
7ed759a
Merge branch 'main' into person/gageorgiev/log-format-deprecate
gabrielgeorgiev1 Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/vdk-plugins/vdk-logging-format/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# This plugin has been deprecated; please use vdk-structlog instead.

This plugins allows for the configuration of the format of VDK logs.

# TEXT
Expand Down
11 changes: 11 additions & 0 deletions projects/vdk-plugins/vdk-logging-format/src/vdk/plugin/logging_format/logging_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,17 @@ def vdk_configure(config_builder: ConfigurationBuilder):

@hookimpl(tryfirst=True)
def vdk_start(plugin_registry: IPluginRegistry, command_line_args: List):
log = logging.getLogger(__name__)
log.warning(
"-------------------------------------------------------------------------"
)
log.warning(
"Vdk-logging-format has been deprecated; please use vdk-structlog instead."
)
log.warning(
"-------------------------------------------------------------------------"
)

logging_format = os.getenv("VDK_LOGGING_FORMAT")
if (
logging_format == "JSON"
Expand Down