vdk-structlog: fix filtering of metadata fields for json #2874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/structlog-json-filtering
branch
2 times, most recently
from
e0372c1 to
274f352
Compare
DeltaMichael
force-pushed
the
person/mdilyan/structlog-json-filtering
branch
from
274f352 to
3416218
Compare
DeltaMichael
force-pushed
the
person/mdilyan/structlog-json-filtering
branch
from
3416218 to
66047d8
Compare
murphp15
reviewed
Nov 13, 2023
projects/vdk-plugins/vdk-structlog/src/vdk/plugin/structlog/structlog_plugin.py
Show resolved
Hide resolved
murphp15
approved these changes
Nov 13, 2023
duyguHsnHsn
approved these changes
Nov 14, 2023
Why? Filtering by timestamp, level and vdk_job_name does not work for json formatting What? - Introduce logic that inserts the correct fields in the json formatter log record - Move the metadata filters after the filters that add the job name - Fix bug in ConsoleMetadataFilters - Add timestamp and function_name to tests - Enable json tests - Add possible values to README.md How was this tested? Ran functional tests locally What kind of change is this? Bugfix Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/structlog-json-filtering
branch
from
66047d8 to
b17d36a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Filtering by timestamp, level and vdk_job_name does not work for json formatting
What?
How was this tested?
Ran functional tests locally
What kind of change is this?
Bugfix
Follow-up
#2875