Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-jupyter: fix skipped tests #2871

Merged
merged 35 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
0d1a369
vdk-jupyterlab-extensions: update dependencies
Nov 2, 2023
380774e
vdk-jupyterlab-extensions: update dependencies
Nov 2, 2023
86e34ac
vdk-jupyterlab-extensions: run tests in cicd
Nov 2, 2023
ddaf281
Merge branch 'main' into person/murphp15/cicd_tests_running
murphp15 Nov 2, 2023
7825c0b
vdk-jupyterlab-extensions: run tests in cicd
Nov 2, 2023
fccc6bc
vdk-jupyterlab-extensions: run tests in cicd
Nov 3, 2023
bcb23a1
vdk-jupyterlab-extensions: run tests in cicd
Nov 3, 2023
8db171f
vdk-jupyterlab-extensions: run tests in cicd
Nov 3, 2023
7618a27
vdk-jupyterlab-extensions: fix failing test
Nov 3, 2023
aa02826
vdk-jupyterlab-extensions: fix failing test
Nov 3, 2023
796e498
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2023
74c3c6f
Merge branch 'main' into person/murphp15/fix_failing_playwright_test
murphp15 Nov 3, 2023
3580490
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 3, 2023
bc55699
vdk-jupyterlab-extensions: fix failing test
Nov 3, 2023
17d2df7
vdk-jupyterlab-extensions: fix failing test
Nov 3, 2023
e5053fc
Merge branch 'main' into person/murphp15/fix_failing_playwright_test
murphp15 Nov 3, 2023
a26c607
vdk-jupyter: include test report
Nov 3, 2023
9246383
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 6, 2023
7645fa4
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 7, 2023
f12b499
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 8, 2023
abe24c7
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 9, 2023
f64b2ce
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 9, 2023
60e4d39
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 9, 2023
a1b91dd
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 10, 2023
52938b8
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 13, 2023
86b2dc9
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 13, 2023
82d03b0
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 13, 2023
dba94b3
jupyter: fix it test
Nov 13, 2023
dff6684
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 13, 2023
e12c1b7
jupyter: fix it test
Nov 13, 2023
4261b1d
jupyter: fix it test
Nov 13, 2023
8f936cd
jupyter: fix it test
Nov 13, 2023
1e2bca8
jupyter: fix it test
Nov 13, 2023
47b41b2
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 13, 2023
0440972
Merge main into person/murphp15/fix_failing_playwright_test
github-actions[bot] Nov 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ test.describe('convert job', () => {

await page.goto(`tree/${tmpPath}`);
});
test.skip('success', async ({ page }) => {
// This Test can fail locally because the paths are too long.
test('success', async ({ page }) => {
// use VDK menu
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Convert').click();
Expand All @@ -38,8 +39,9 @@ test.describe('convert job', () => {
.locator('div')
.filter({ hasText: 'Are you sure you want to convert the Data Job' });
await page.getByRole('button', { name: 'OK' }).click();
await page.locator('div').filter({ hasText: 'Directory not found' });
await page.getByRole('button', { name: 'Dismiss' }).click();

// Dismiss the dialog that says the operation is running in the background
await page.getByRole('button', { name: 'OK' }).click();

// get message that the job was converted successfully
await page
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ test('should try to create a job with incorrect input and get error', async ({
await page.getByRole('button', { name: 'OK' }).click();
});

test.skip('should try to create a job successfully', async ({ page }) => {
test('should try to create a job successfully', async ({ page }) => {
await page.goto('');
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Create').click();
Expand All @@ -105,7 +105,7 @@ test.skip('should try to create a job successfully', async ({ page }) => {
page.on('dialog', async dialog => {
expect(dialog.type()).toContain('alert');
expect(dialog.message()).toContain(
'Job with name first-job was created successfully!'
'Job with name first-job was created only locally'
);
await dialog.accept();
});
Expand Down Expand Up @@ -146,7 +146,7 @@ test('should create an init cell when opening a new notebook', async ({
).toBeVisible();
});

test.skip(
test(
'should create a new dir, navigate to it,' +
'create a new job, attempt to create a job relative to' +
'the original dir and succeed',
Expand All @@ -158,7 +158,6 @@ test.skip(
await page.getByText('test-dir').click();
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Create').click();
await page.getByLabel('Local').check();
await page.getByLabel('Job name:').click();
await page.getByLabel('Job name:').fill('first-job');
await page.getByLabel('Job team:').click();
Expand Down