Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-jupyter: run tests in CI #2868

Merged
merged 8 commits into from
Nov 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions projects/vdk-plugins/vdk-jupyter/.plugin-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,28 @@ build-vdk-jupyterlab-extension:
- echo "Building VDK JupyterLab Extension..."
- npm rebuild

integration-tests-vdk-jupyterlab-extension:
image: "mcr.microsoft.com/playwright:v1.39.0-jammy"
# extends: .common-setup-vdk-jupyterlab-extension
stage: pre_release_test
script:
- cd projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension
- apt update
- apt install software-properties-common -y
- add-apt-repository ppa:deadsnakes/ppa
- DEBIAN_FRONTEND=noninteractive apt install python3.9 python3.9-venv -y
- python3.9 -m venv venv
- source venv/bin/activate
- pip install -U pip
- apt-get install -y gcc python3.9-dev
- pip install -e .
- npm rebuild
- jlpm install
- jlpm build:prod
- cd ./ui-tests
- jlpm install
- jlpm playwright install
- jlpm playwright test

server-tests-vdk-jupyterlab-extension:
extends: .common-setup-vdk-jupyterlab-extension
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dependencies = [
"jupyter_server>=1.6,<3",
"jupyterlab==3.6.3",
"traitlets==5.9.0",
"vdk-control-cli>=1.0.11",
"vdk-control-cli>=1.3.1020121059",
"vdk-core>=0.3.1057638781"
]
dynamic = ["version", "description", "authors", "urls", "keywords"]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const baseConfig = require('@jupyterlab/galata/lib/playwright-config');
module.exports = {
...baseConfig,
webServer: {
command: 'jlpm start',
command: 'jlpm start --allow-root',
url: 'http://localhost:8888/lab',
timeout: 200 * 100000,
reuseExistingServer: !process.env.CI
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import path from 'path';
import { copyDirectory } from './utils';
const baseJobPath = 'data/convert-test-job-dirty';
test.use({ autoGoto: false });

test.describe('convert job', () => {
test.beforeEach(async ({ baseURL, page, tmpPath }) => {
await copyDirectory(
Expand All @@ -20,8 +19,7 @@ test.describe('convert job', () => {

await page.goto(`tree/${tmpPath}`);
});

test('success', async ({ page }) => {
test.skip('success', async ({ page }) => {
// use VDK menu
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Convert').click();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/

import { galata } from '@jupyterlab/galata';
import path from 'path';

export async function copyDirectory(
baseURL: string,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ test('should try to create a job with incorrect input and get error', async ({
await page.getByRole('button', { name: 'OK' }).click();
});

test('should try to create a job successfully', async ({ page }) => {
test.skip('should try to create a job successfully', async ({ page }) => {
await page.goto('');
await page.menu.open('VDK');
await page.locator('#jp-vdk-menu').getByText('Create').click();
Expand Down Expand Up @@ -146,7 +146,7 @@ test('should create an init cell when opening a new notebook', async ({
).toBeVisible();
});

test(
test.skip(
'should create a new dir, navigate to it,' +
'create a new job, attempt to create a job relative to' +
'the original dir and succeed',
Expand Down