vdk-core: implement config option for logging execution result #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
from
d510fb0 to
f80ee04
Compare
gabrielgeorgiev1
approved these changes
Oct 24, 2023
|
Please add tests. I think the easiest way to test them would be with functional test: the result object contain stderr and std out which you can inspect for verification. |
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
4 times, most recently
from
b0c3fcb to
d04b8fe
Compare
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
4 times, most recently
from
4fd4874 to
669ce77
Compare
DeltaMichael
pushed a commit
that referenced
this pull request
Oct 30, 2023
Why? User reasearch indicates that the execution result is too verbose for local runs. Users don't expect a lot of output for successful jobs and expect error output for failing jobs. What? Introduce the LOG_EXECUTION_RESULT config option that enables/disables displaying the end result. Enabling and disabling the end result will be implemented in a separate PR. #2831 How was this tested? CI What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
changed the base branch from
main
to
person/mdilyan/log-end-result-conf
DeltaMichael
changed the title
DeltaMichael
added a commit
that referenced
this pull request
Oct 30, 2023
## Why? User reasearch indicates that the execution result is too verbose for local runs. Users don't expect a lot of output for successful jobs and expect error output for failing jobs. ## What? Introduce the LOG_EXECUTION_RESULT config option that enables/disables displaying the end result. Enabling and disabling the end result will be implemented in a separate PR. #2831 ## How was this tested? CI ## What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
from
5b1ae52 to
67d3cf8
Compare
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
from
67d3cf8 to
87880a6
Compare
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
2 times, most recently
from
0a1793c to
1cd13d7
Compare
projects/vdk-core/src/vdk/internal/builtin_plugins/run/cli_run.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/run/cli_run.py
Outdated
Show resolved
Hide resolved
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
2 times, most recently
from
76c87dd to
a1f4872
Compare
antoniivanov
approved these changes
Nov 14, 2023
Why? User reasearch indicates that the execution result is too verbose for local runs. Users don't expect a lot of output for successful jobs and expect error output for failing jobs. What? Introduce the LOG_EXECUTION_RESULT config option that enables/disables displaying the end result. How was this tested? Ran locally with successful and failing jobs Functional tests What kind of change is this? Feature/non-breaking Signed-off-by: Dilyan Marinov <[email protected]>
DeltaMichael
force-pushed
the
person/mdilyan/log-end-result
branch
from
a1f4872 to
27431f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
User reasearch indicates that the execution result is too verbose for local runs. Users don't expect a lot of output for successful jobs and expect error output for failing jobs.
What?
Introduce the LOG_EXECUTION_RESULT config option that enables/disables displaying the end result.
Config Error Output
https://pastebin.com/raw/MvJX0u9m
User Error Output
https://pastebin.com/raw/0MxZp6Zg
Success Output
https://pastebin.com/raw/GTNBiEFG
How was this tested?
Ran locally with successful and failing jobs
What kind of change is this?
Feature/non-breaking