-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-core: VdkBoundLogger #2823
Merged
Merged
vdk-core: VdkBoundLogger #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces the VdkBoundLogger and addresses #2802. Testing done: locally tested Signed-off-by: Gabriel Georgiev <[email protected]>
for more information, see https://pre-commit.ci
projects/vdk-core/src/vdk/internal/builtin_plugins/config/log_config.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
…rsatile-data-kit into person/gageorgiev/bound-logger Signed-off-by: Gabriel Georgiev <[email protected]>
for more information, see https://pre-commit.ci
DeltaMichael
approved these changes
Oct 24, 2023
antoniivanov
approved these changes
Oct 24, 2023
Signed-off-by: Gabriel Georgiev <[email protected]>
…rsatile-data-kit into person/gageorgiev/bound-logger Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the VdkBoundLogger and addresses #2802.
Testing done: locally tested, ran a job with the following job code:
And the following config:
And observed the following logs: