-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: Add vdk-heartbeat image #281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
reviewed
Sep 24, 2021
mivanov1988
reviewed
Sep 24, 2021
mivanov1988
reviewed
Sep 24, 2021
2a0a994
to
383bfb2
Compare
mivanov1988
reviewed
Oct 1, 2021
mivanov1988
reviewed
Oct 1, 2021
383bfb2
to
113eb9c
Compare
antoniivanov
requested changes
Oct 4, 2021
113eb9c
to
0944636
Compare
antoniivanov
reviewed
Oct 4, 2021
8b3f4fe
to
a470977
Compare
antoniivanov
reviewed
Oct 5, 2021
As part of the the CI/CD process, we could benefit from having the vdk-heartbeat package built as a docker image. This change adds a dockerfile to facilitate building the vdk-heartbeat docker image when a new release of the Control Service is made. Testing Done: Built the image in docker locally and ran it to verify that it is being executed as expected. Signed-off-by: Andon Andonov <[email protected]>
a470977
to
0320b18
Compare
antoniivanov
reviewed
Oct 5, 2021
mivanov1988
approved these changes
Oct 5, 2021
antoniivanov
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the the CI/CD process, we could benefit from
having the vdk-heartbeat package built as a docker image.
This change adds a dockerfile to facilitate building the
vdk-heartbeat docker image when a new release of the
Control Service is made.
Testing Done: Built the image in docker locally and
ran it to verify that it is being executed as expected.
Signed-off-by: Andon Andonov [email protected]