Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: Remove databases from DB_DEFAULT_TYPE description #272

Merged
merged 2 commits into from
Sep 21, 2021
Merged

vdk-core: Remove databases from DB_DEFAULT_TYPE description #272

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fdf3fb
vdk-core: Remove databases from DB_DEFAULT_TYPE description
gabrielgeorgiev1 Sep 21, 2021
0514df1
Merge branch 'main' into person/gageorgiev/config-help-remove-todo
gabrielgeorgiev1 Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions projects/vdk-core/src/vdk/internal/builtin_plugins/config/vdk_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ def vdk_configure(self, config_builder: ConfigurationBuilder) -> None:
db_default_type_description = (
"Default DB connection provided by VDK when executing a data job. "
"All sql queries, templates/loads would be against that database."
"Different database types can be configured with plugins. "
"Current supported database types: TODO \n"
"Different database types can be configured with plugins. \n"
)
config_builder.add(DB_DEFAULT_TYPE, None, True, db_default_type_description)

Expand Down