vdk-core: make sure standalone data job doesn't run steps #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standalone Data Job ignores directory provided steps and doesn't run them (at least not currently). But if a plugin adds more steps , this logic does not work and it runs the steps adde by the plugin. In our case vdk-notebook add new notebook steps and they are run . This causes when a new notebook is created and job_input is intiailzied , during initializaiton it tries to run all steps in the notebook. This fixes this issue by adding explicit function after initialize_job that replaces all steps with noop step.
duyguHsnHsn
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standalone Data Job ignores directory provided steps and doesn't run them (at least not currently).
But if a plugin adds more steps , this logic does not work and it runs the steps adde by the plugin. In our case vdk-notebook add new notebook steps and they are run . This causes when a new notebook is created and job_input is intiailzied , during initializaiton it tries to run all steps in the notebook.
This fixes this issue by adding explicit function after initialize_job that replaces all steps with noop step.