vdk-control-api-auth: vdk credentials cache refactoring #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyguHsnHsn
approved these changes
Aug 25, 2023
This is refactoring the credentials cache storage system to make it more reusable . Particulary I want to reuse it to get corrected authenticated user in telemetry later. - We are providing explcit interface for credentials cache intead of using Union of classes - Implement SingletonInMemoryCredentials cache to enable different parts of the program to easily access and reuse the same credentials. - Added method read_cached_access_token_only and use it in get_authenticated_username() to make it easier to record user using vdk even if his token has expired. - Default credentials_cache to LocalFolderCredentialsCache which is more commonly used. - Deprecate cache_locally in favour of explicitly passing the credential cache instance, this is better design pattern.
antoniivanov
force-pushed
the
person/aivanov/vdk-control-api-auth
branch
from
5650d18 to
dbaeb8d
Compare
mrMoZ1
approved these changes
Aug 25, 2023
yonitoo
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is refactoring the credentials cache storage system to make it more reusable . Particulary I want to reuse it to get corrected authenticated user in telemetry later.