vdk-jupyter: optimize ConvertToJobNotebook notes #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/jupyter
branch
from
478d091 to
6432529
Compare
|
Can you add the text in the drop downs to the PR descriptions |
duyguHsnHsn
approved these changes
Aug 25, 2023
Try to split out in one more section the notes after the conversion. Also make them collapssable so they do not appear as so much text and user can click to see more info if they want.
antoniivanov
force-pushed
the
person/aivanov/jupyter
branch
from
6432529 to
4052afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to split out in one more section the notes after the conversion.
Also make them collapssable so they do not appear as so much text and user can click to see more info if they want.
You can see how it looks here:
And with the text expanded: