vdk-ipython: infer correctly job name and add more tests #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/ipython
branch
from
9f2d404 to
d101cad
Compare
antoniivanov
force-pushed
the
person/aivanov/ipython
branch
4 times, most recently
from
7314215 to
8e7e3d3
Compare
If job name is not explcitly provided we should infer it correctly from the path name. Also I extended ipython test coverage to cover most of the other untested job input methods
Co-authored-by: Dilyan Marinov <[email protected]>
antoniivanov
force-pushed
the
person/aivanov/ipython
branch
from
a75a0fb to
5b97791
Compare
DeltaMichael
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If job name is not explcitly provided we should infer it correctly from the path name.
Also I extended ipython test coverage to cover most of the other untested job input methods