control-service: Convert debug logs to info #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielgeorgiev1
approved these changes
Sep 20, 2021
When a requirements.txt file of a data job is broken, a platform error is raised, because the Control Service is not able to get the logs from the builder k8s pod. Currently, we cannot properly investigate what are the reasons for that, as we don't log enough data in the control service's log stream. This change converts some of the debug log messages to info messages to allow for a better view over the possible reason for the service not being able to get the logs from the builder pods. Testing Done: Logging change. New logs appear in the Control Service log stream. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/job-deployments-misclassification
branch
from
4dd5d2d to
2c40ef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a requirements.txt file of a data job is broken,
a platform error is raised, because the Control Service
is not able to get the logs from the builder k8s pod.
Currently, we cannot properly investigate what are the
reasons for that, as we don't log enough data in the control
service's log stream.
This change converts some of the debug log messages to info messages
to allow for a better view over the possible reason for the service
not being able to get the logs from the builder pods.
Testing Done: New log message appear alongside the
regular logs.
Signed-off-by: Andon Andonov [email protected]