frontend: Fix for e2e test #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix one bug in e2e tests for Data Job Executions Signed-off-by: Goran Kokinovski <[email protected]>
gorankokin
added
the
area/frontend
DeltaMichael
approved these changes
Aug 16, 2023
yonitoo
approved these changes
Aug 16, 2023
|
can you please explain what was the bug in the description ? Though I think I get it. The bug is that if the grid is empty it crashes the test? But I am not sure 100% |
antoniivanov
approved these changes
Aug 16, 2023
|
@antoniivanov Added some more details to description |
DeltaMichael
deleted the
person/gkokinovski/fix-intermittent-frontend-e2e-test-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
find('[data-cy=data-pipelines-job-executions-type-container]')causes the test to fail if it doesn't find any job executions. It should be returning an empty list instead.What
Introduce logic that returns an empty list
How was this tested
Ran e2e tests locally
Ran e2e tests in CI
What type of change is this
Bug fix