control-service: remove hardcoded image pull policy from job deployer #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <[email protected]>
mivanov1988
reviewed
Aug 16, 2023
projects/control-service/projects/helm_charts/pipelines-control-service/values.yaml
Outdated
Show resolved
Hide resolved
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 16, 2023 18:23
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
approved these changes
Aug 16, 2023
mivanov1988
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: removed hardcoded imagePullPolicy from the JobImageDeployer service.
why:
Currently, the "Always" strategy fetches the latest version of the image from the registry. This results in an unnecessary image pulls.
Switching to the "IfNotPresent" strategy will address this issue. With this strategy, images will be pulled only if they are not already present in the local cache, matching the behavior of our data jobs that use exact tags associated with the current version. This will reduce unnecessary network calls to the Docker Registry.
testing: trivial