vdk-control-cli: Add python_version to sample config.ini #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mivanov1988
approved these changes
Aug 16, 2023
projects/vdk-control-cli/src/vdk/internal/control/job/sample_job/config.ini
Show resolved
Hide resolved
antoniivanov
approved these changes
Aug 16, 2023
This change adds the `python_version` property to the config.ini file of the sample data job that is returned when a user executes `vdk create -n <job-name> -t <team-name>`. The property is commented out, as it is used only if a user wants to set a python version different from the default one. Testing Done: Executed `vdk create -n my-test-job -t my-team` locally, and verified that the python_version property is present in the generated data job's config.ini file. Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/sample-job-update
branch
from
cb32b45 to
8d8e49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
python_versionproperty to the config.ini file of the sample data job that is returned when a user executesvdk create -n <job-name> -t <team-name>. The property is commented out, as it is used only if a user wants to set a python version different from the default one.Testing Done: Executed
vdk create -n my-test-job -t my-teamlocally, and verified that the python_version property is present in the generated data job's config.ini file.