control-service: Include additional labels for service template #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
approved these changes
Sep 17, 2021
Currently, there is no way for a control-service deployment to add additional labels for their service instance. This change allows the addition of such through Values.yml. Testing done: generated template locally using helm install --dry-run and verified the additional labels are added correctly and are formatted appropriately Signed-off-by: gageorgiev <[email protected]>
gabrielgeorgiev1
force-pushed
the
person/gageorgiev/include-add-labels-service
branch
from
98eea89 to
f7c777b
Compare
gabrielgeorgiev1
deleted the
person/gageorgiev/include-add-labels-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way for a control-service deployment to
add additional labels for their service instance. This change
allows the addition of such through Values.yml.
Testing done: generated template locally using helm install
--dry-run and verified the additional labels are added correctly
and are formatted appropriately
Signed-off-by: gageorgiev [email protected]