vdk-audit: [bug fix] Fix incorrectly detected event #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in the `_audit()` method filters the forbidden events and detects if an executed event is allowed or not. However, the way it matches the events is by partial string match (the `event in not_permitted_event` part). This means that if a forbidden event is, e.g., `os.removexattr` and the event that is passed to the method is `os.remove`, there will be a match, because `os.remove` is a sub-string of `os.removexattr`. With this change, the `_audit()` method switches to exact string match when filtering for forbidden events, in order to avoid situations where unexpected events are matched. Testing done: Added test Signed-off-by: Andon Andonov <[email protected]>
antoniivanov
approved these changes
Aug 10, 2023
gabrielgeorgiev1
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in the
_audit()method filters the forbidden events and detects if an executed event is allowed or not. However, the way it matches the events is by partial string match (theevent in not_permitted_eventpart). This means that if a forbidden event is, e.g.,os.removexattrand the event that is passed to the method isos.remove, there will be a match, becauseos.removeis a sub-string ofos.removexattr.With this change, the
_audit()method switches to exact string match when filtering for forbidden events, in order to avoid situations where unexpected events are matched.Testing done: Added test