-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-jupyter: add testing to CI/CD #2541
vdk-jupyter: add testing to CI/CD #2541
Conversation
It is very important to test this with failing cases and make sure the report makes it obvious which tests have failed. |
That's a very good point. Let us get into practice for tests to verify the "failing" logs, we should link a fail CI or uploaded failed logs in the Testing Done section so other people can see if they find it easy to understand the problem (since what is easy to see to me often it is not so to someone else). |
2872165
to
f108311
Compare
Can you please add in testing done links to "failed" (even if faked) runs of gitlab tests so that we can see how easy it is to find the issue. Sort of like testing the error scenario for the CICD. |
I clicked to update your branch becasue there were some unrelated tests getting started. But it did not work properly. The frontend tests are missing from the test report: https://gitlab.com/vmware-analytics/versatile-data-kit/-/pipelines/978573326/test_report |
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
188a2e1
to
42336ab
Compare
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Signed-off-by: Yoan Salambashev <[email protected]>
Addressed. The Frontend tests are not showing up in the test report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good . Thanks!
What:
Add test stage to the .plugin-ci.yml file of the vdk-jupyter plugin.
Why:
Right now, there is a build and release stage but we would want to run the tests every time to ensure code robustness.
Testing Done:
The Gitlab pipeline is green.
Signed-off-by: Yoan Salambashev [email protected]