control-service: add file filter before job upload #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
reviewed
Aug 9, 2023
...ects/pipelines_control_service/src/main/java/com/vmware/taurus/service/upload/JobUpload.java
Outdated
Show resolved
Hide resolved
antoniivanov
requested changes
Aug 9, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/upload/JobUploadFileFilter.java
Outdated
Show resolved
Hide resolved
...ines_control_service/src/main/java/com/vmware/taurus/service/upload/JobUploadFileFilter.java
Outdated
Show resolved
Hide resolved
...jects/pipelines_control_service/src/main/resources/org.apache.tika.mime/custom-mimetypes.xml
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Aug 10, 2023
...ines_control_service/src/main/java/com/vmware/taurus/service/upload/JobUploadFileFilter.java
Outdated
Show resolved
Hide resolved
murphp15
reviewed
Aug 10, 2023
...jects/pipelines_control_service/src/test/resources/org/apache/tika/mime/custom-mimetypes.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
Signed-off-by: mrMoZ1 <[email protected]>
...rol_service/src/main/java/com/vmware/taurus/service/upload/JobUploadFilterListValidator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mrMoZ1 <[email protected]>
antoniivanov
approved these changes
Aug 17, 2023
doks5
approved these changes
Aug 18, 2023
.../control-service/projects/pipelines_control_service/src/test/resources/filter-job/config.ini
Outdated
Show resolved
Hide resolved
.../control-service/projects/pipelines_control_service/src/test/resources/filter-job/config.ini
Outdated
Show resolved
Hide resolved
added 2 commits
August 18, 2023 12:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what: Refactored current job filtering logic to rely on inheritance and templates, providing more flexibility for future refactoring of required filtering. In addition to the already present allow list - added a filter list that deletes file types matched from a comma separated property before uploading data job source code files to version control/building job the image.
why: Currently users encounter challenges while deploying data jobs due to the presence of compiled Python files (*.pyc) that conflict with the upload validation process. This hinders their ability to redeploy jobs, especially when working with Jupyter Notebooks. To enhance the user experience and streamline the deployment process, we need to implement a file exclusion mechanism similar to .gitignore logic during data job uploads.
testing: added unit test