Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-jupyter: make run before deploy optional #2525

Merged
merged 13 commits into from
Aug 21, 2023

Conversation

duyguHsnHsn
Copy link
Collaborator

@duyguHsnHsn duyguHsnHsn commented Aug 7, 2023

What: Added a checkbox button that determines whether the job will be run once before deployment.
Screenshot 2023-08-21 at 10 19 53

Why: Currently, the job is always running but in some use cases the users might not want it.

Testing: modified the jest tests
Signed-off-by: Duygu Hasan [email protected]

@antoniivanov
Copy link
Collaborator

As usual for new UI elements, please provide a screenshot

@duyguHsnHsn duyguHsnHsn force-pushed the person/hduygu/vdk-jupyter-run-before-deploy branch from 98c210d to 782474a Compare August 8, 2023 05:48
Copy link
Contributor

@yonitoo yonitoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@murphp15
Copy link
Collaborator

murphp15 commented Aug 8, 2023

Does this run it locally?
why would you want to run before deployment?
If you wanted to run it before deployment would you not just run it using the start button?

@duyguHsnHsn
Copy link
Collaborator Author

Does this run it locally? why would you want to run before deployment? If you wanted to run it before deployment would you not just run it using the start button?

Mainly to ensure that the deployed job will be green. Yes, it is always an option for them to run it manually like that this option is added just for convenience.
Imagine doing some config.ini changes, not changes in the code u might actually forget about running it again, this works both as reminder and if the run fails u get an error message and the job is not deployed, but if it is green u get no update on the run but directly the jo bis deployed

@duyguHsnHsn duyguHsnHsn force-pushed the person/hduygu/vdk-jupyter-run-before-deploy branch from ab2f3ea to 7e09675 Compare August 17, 2023 07:14
@duyguHsnHsn duyguHsnHsn merged commit a9e2fe5 into main Aug 21, 2023
@duyguHsnHsn duyguHsnHsn deleted the person/hduygu/vdk-jupyter-run-before-deploy branch August 21, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants