-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vdk-jupyter: make run before deploy optional #2525
vdk-jupyter: make run before deploy optional #2525
Conversation
As usual for new UI elements, please provide a screenshot |
98c210d
to
782474a
Compare
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Outdated
Show resolved
Hide resolved
Does this run it locally? |
Mainly to ensure that the deployed job will be green. Yes, it is always an option for them to run it manually like that this option is added just for convenience. |
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Outdated
Show resolved
Hide resolved
...s/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/__tests__/show-dialog-deploy.spec.tsx
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Outdated
Show resolved
Hide resolved
projects/vdk-plugins/vdk-jupyter/vdk-jupyterlab-extension/src/components/DeployJob.tsx
Outdated
Show resolved
Hide resolved
ab2f3ea
to
7e09675
Compare
…com:vmware/versatile-data-kit into person/hduygu/vdk-jupyter-run-before-deploy
What: Added a checkbox button that determines whether the job will be run once before deployment.

Why: Currently, the job is always running but in some use cases the users might not want it.
Testing: modified the jest tests
Signed-off-by: Duygu Hasan [email protected]