vdk-core: Add flag to JobConfig in case config file is required #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the vdk-core's JobConfig does not require the presense of a config file in a data job's repository. This works in general, but not for the vdk-control-cli's use-cases, where the presense of the config file is mandatory. This change adds a `should_fail_missing_config` flag to JobConfig, which can be used when the presense of the config file is necessary. If the flag is set to `True`, and the config file is missing in the data job's folder, a VdkConfigurationError will be raised. Testing Done: Added test Signed-off-by: Andon Andonov <[email protected]>
gabrielgeorgiev1
approved these changes
Aug 7, 2023
antoniivanov
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the vdk-core's JobConfig does not require the presense of a config file in a data job's repository. This works in general, but not for the vdk-control-cli's use-cases, where the presense of the config file is mandatory.
This change adds a
should_fail_missing_configflag to JobConfig, which can be used when the presense of the config file is necessary. If the flag is set toTrue, and the config file is missing in the data job's folder, a VdkConfigurationError will be raised.Testing Done: Added test