Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specs: VEP-2420: Getting started with your Data #2519

Merged
merged 16 commits into from
Aug 14, 2023
Merged

specs: VEP-2420: Getting started with your Data #2519

merged 16 commits into from
Aug 14, 2023

Conversation

murphp15
Copy link
Collaborator

@murphp15 murphp15 commented Aug 3, 2023

No description provided.

@murphp15 murphp15 changed the title docs: fix config examples through project specs: VEP-2420: Getting started with your Data Aug 3, 2023
@murphp15
Copy link
Collaborator Author

murphp15 commented Aug 9, 2023

@antoniivanov I would love if you could review this again.
I am tempted to remove entirely the sections: Layer's of abstraction are not clear and Not obvious what properties do .
The will be handled by the source/sink initiative.

WDYT?

@antoniivanov
Copy link
Collaborator

@antoniivanov I would love if you could review this again. I am tempted to remove entirely the sections: Layer's of abstraction are not clear and Not obvious what properties do . The will be handled by the source/sink initiative.

WDYT?

Yes. Put them in non-goals explicitly with comment that they would he handled as part of #2422

duyguHsnHsn
duyguHsnHsn approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@duyguHsnHsn duyguHsnHsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@antoniivanov antoniivanov merged commit e51878b into main Aug 14, 2023
@antoniivanov antoniivanov deleted the person/murphp15/motiviation_section_for_vep_2420 branch August 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeltaMichael DeltaMichael DeltaMichael left review comments

@antoniivanov antoniivanov antoniivanov approved these changes

@duyguHsnHsn duyguHsnHsn duyguHsnHsn approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murphp15 @antoniivanov @duyguHsnHsn @DeltaMichael @vmwclabot