vdk-control-api-auth: add get_authenticated_username #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniivanov
force-pushed
the
person/aivanov/vdk-control-api-auth
branch
from
f7e70ee to
4dd9db7
Compare
doks5
approved these changes
Aug 7, 2023
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Outdated
Show resolved
Hide resolved
antoniivanov
force-pushed
the
person/aivanov/vdk-control-api-auth
branch
from
4dd9db7 to
7978c00
Compare
antoniivanov
commented
Aug 8, 2023
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Outdated
Show resolved
Hide resolved
antoniivanov
commented
Aug 8, 2023
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Show resolved
Hide resolved
murphp15
reviewed
Aug 8, 2023
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Show resolved
Hide resolved
murphp15
reviewed
Aug 8, 2023
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Show resolved
Hide resolved
murphp15
reviewed
Aug 8, 2023
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Outdated
Show resolved
Hide resolved
antoniivanov
force-pushed
the
person/aivanov/vdk-control-api-auth
branch
from
4e87f90 to
7fea9ab
Compare
Add to Authentication library a method to get_authenticated_username. The purpose of this method is ot be used during debugging , in logging and in telemetry use cases. Testing Done: unit tests
antoniivanov
force-pushed
the
person/aivanov/vdk-control-api-auth
branch
from
7fea9ab to
329c515
Compare
antoniivanov
commented
Aug 8, 2023
projects/vdk-plugins/vdk-control-api-auth/src/vdk/plugin/control_api_auth/authentication.py
Outdated
Show resolved
Hide resolved
…ol_api_auth/authentication.py
antoniivanov
commented
Aug 8, 2023
projects/vdk-plugins/vdk-control-api-auth/tests/test_get_auth_user.py
Outdated
Show resolved
Hide resolved
murphp15
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to Authentication library a method to get_authenticated_username.
The purpose of this method is ot be used during debugging , in logging and in telemetry use cases.
Testing Done: unit tests